Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent NPE in TcpSyslogMessageSender.close() #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

prevent NPE in TcpSyslogMessageSender.close() #83

wants to merge 1 commit into from

Conversation

AmirWiener
Copy link

TcpSyslogMessageSender.close() method is public, and can be called from outside.
However, the socket is private and it's value can't be verified.
Since trying to close a null socket makes no sense, wrapping it with a null check is requested.

@pmconrad
Copy link

pmconrad commented May 6, 2023

This is already in #45, which adds the same check also for UDPMessageSender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmirWiener @pmconrad